Allow customizing the list of monitored network interfaces #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple way to customize the selection of network interfaces. If INTERFACE_NAMES_OVERRIDE is set in muninlite.conf, that list is used instead of auto-detection. As muninlite.conf itself is also a script, it is even possible to write a custom command. This feature is helpful in environments with virtual machines or containers, like docker or lxc where there are lots of br-*, veth*, lxcbr* etc interfaces where monitoring doesn't make much sense. I didn't find a way to reliably filter physical interfaces.
./muninlite: 651: INTERFACE_NAMES_OVERRIDE: parameter not set
kenyon
approved these changes
Dec 13, 2023
Co-authored-by: Kenyon Ralph <[email protected]>
|
I'd like to avoid having the defaults in 2 different places. Specially since they are not exactly the same. So, either have :
1 would be my preference as |
|
The location in muninlite.in is also always executed, except the PLUGINS list was reconfigured. but I can remove that commented line from the config if that's the matter. Btw for my installation, I changed it even further, to only include active network interfaces: I think it's worth keeping these expressions at least as a form of documentation. |
|
Dear @munin-monitoring, do you progress? |
rany2
added a commit
to rany2/openwrt_packages
that referenced
this pull request
Jan 2, 2025
As muninlite doesn't appear to have had a release in a few years and activity on the git repo appears to have stalled, we add some patches on our end for now. Patches: - 001->004 are upstream fixes from master. - 100 is a submitted PR: munin-monitoring/muninlite#19 to fix munin-monitoring/muninlite#14. - 200->204 is a submitted PR to allow customizing the monitored network interfaces: munin-monitoring/muninlite#18. Despite the large number of patches it is actually a trivial change. Signed-off-by: Rany Hany <[email protected]>
rany2
added a commit
to rany2/openwrt_packages
that referenced
this pull request
Jan 2, 2025
As muninlite doesn't appear to have had a release in a few years and activity on the git repo appears to have stalled, we add some patches on our end for now. Patches: - 001->004 are upstream fixes from master. - 100 is a submitted PR: munin-monitoring/muninlite#19 to fix munin-monitoring/muninlite#14. - 200->204 is a submitted PR to allow customizing the monitored network interfaces: munin-monitoring/muninlite#18. Despite the large number of patches it is actually a trivial change. Signed-off-by: Rany Hany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple way to customize the selection of network interfaces. If
INTERFACE_NAMES_OVERRIDEis set inmuninlite.conf, that list is used instead of auto-detection. Asmuninlite.confitself is also a script, it is even possible to write a custom command.This feature is helpful in environments with virtual machines or containers, like docker or lxc where there are lots of
br-*,veth*,lxcbr*etc interfaces where monitoring doesn't make much sense. I didn't find a way to reliably filter physical interfaces.